Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render regression: khal Padding widh > size #798

Merged

Conversation

penguinolog
Copy link
Collaborator

@penguinolog penguinolog commented Feb 12, 2024

Allow to render Padding with GIVEN width > size.
Warn about incorrect size

Fix: pimutils/khal#1334

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 7871129273

Details

  • 0 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 70.883%

Totals Coverage Status
Change from base Build 7868637269: 0.007%
Covered Lines: 8777
Relevant Lines: 12465

💛 - Coveralls

Allow to render `Padding` with GIVEN width > size.
Warn about incorrect size

Fix: pimutils/khal#1334
@penguinolog penguinolog force-pushed the khal_insufficient_padding_width branch from 827be99 to be2ddab Compare February 12, 2024 11:35
@penguinolog penguinolog merged commit 7bb79ba into urwid:master Feb 12, 2024
35 checks passed
@penguinolog penguinolog deleted the khal_insufficient_padding_width branch February 12, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ikhal crashes to create new events
2 participants