Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Text pack for layout without pack #819

Merged
merged 1 commit into from Feb 20, 2024
Merged

Conversation

penguinolog
Copy link
Collaborator

  • fix minor type checks
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* fix minor type checks
@github-actions github-actions bot added docs Issues related to documentation Tests Tests and removed Widget labels Feb 20, 2024
@@ -338,7 +338,8 @@ def pack(self, size: tuple[int] | tuple[()] | None = None, focus: bool = False)
if size:
(maxcol,) = size
if not hasattr(self.layout, "pack"):
return size
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7972941444

Details

  • -6 of 21 (71.43%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 71.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/widget/scrollable.py 0 1 0.0%
urwid/widget/frame.py 7 9 77.78%
urwid/display/_raw_display_base.py 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
urwid/listbox.py 1 83.78%
Totals Coverage Status
Change from base Build 7960646132: -0.005%
Covered Lines: 8931
Relevant Lines: 12634

💛 - Coveralls

@penguinolog penguinolog merged commit 34005e2 into urwid:master Feb 20, 2024
35 checks passed
@penguinolog penguinolog deleted the fixes branch February 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs Issues related to documentation Tests Tests Widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants