Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeWidget: do not use deprecated API in update_expanded_icon #832

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

penguinolog
Copy link
Collaborator

  • Typing: Make Padding and Overlay generic classes
  • Extend tests for TreeListBox: cover a deep nested scenario
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* Typing: Make `Padding` and `Overlay` generic classes
* Extend tests for `TreeListBox`: cover a deep nested scenario
@github-actions github-actions bot added docs Issues related to documentation Widget labels Feb 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8003697818

Details

  • -1 of 14 (92.86%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/widget/overlay.py 8 9 88.89%
Totals Coverage Status
Change from base Build 8003129794: 0.2%
Covered Lines: 9137
Relevant Lines: 12666

💛 - Coveralls

@penguinolog penguinolog merged commit 4743e4c into urwid:master Feb 22, 2024
35 checks passed
@penguinolog penguinolog deleted the tree_undeprecate branch February 22, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs Issues related to documentation Tests Tests Widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants