Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Overlay not accepted relative positioning #854

Merged
merged 1 commit into from Mar 4, 2024

Conversation

penguinolog
Copy link
Collaborator

@penguinolog penguinolog commented Mar 4, 2024

Fix: #851

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8137458297

Details

  • 15 of 19 (78.95%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 74.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/widget/overlay.py 15 19 78.95%
Totals Coverage Status
Change from base Build 8136949564: 0.05%
Covered Lines: 9290
Relevant Lines: 12625

💛 - Coveralls

@penguinolog penguinolog force-pushed the regression_ovl_relative branch 4 times, most recently from 5154b9b to 7265959 Compare March 4, 2024 08:22
@penguinolog penguinolog merged commit baadcf8 into urwid:master Mar 4, 2024
35 checks passed
@penguinolog penguinolog deleted the regression_ovl_relative branch March 4, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] urwid.Overlay valign doesn't accept relative any more
2 participants