Support shift key reading for sgrmouse #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: shift accessibility depends on terminal (terminal may intercept "shift mouse press" for keys 1-3) Fix: urwid#857
penguinolog
commented
Mar 13, 2024
| # implemented by using a timer. This timer can check if the last | ||
| # registered click is below a certain threshold. This threshold | ||
| # is normally set in the operating system itself, so setting one | ||
| # here will cause an inconsistent behaviour. I do not plan to use |
There was a problem hiding this comment.
let's remove "I do not plan": somebody can try to implement this really complex feature
penguinolog
commented
Mar 13, 2024
| @@ -310,17 +310,15 @@ def read_sgrmouse_info(self, keys: Collection[int], more_available: bool): | |||
|
|
|||
| (b, x, y) = (int(val) for val in value[:-1].split(";")) | |||
| action = value[-1] | |||
|
|
|||
| # shift, etc. is not communicated on my machine, so I | |||
There was a problem hiding this comment.
other keys was added before, shift was the last one.
Unfortunately, on the most terminal emulators it's not intercepted only with scroll wheel, but now we have the first user and his use case was testable.
Pull Request Test Coverage Report for Build 8262923968Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
shift accessibility depends on terminal
(terminal may intercept "shift mouse press" for keys 1-3)
Fix: #857
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentValidated on the
input_test.py