ScrollBar: fully support __length_hint__ not Sized
#863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
penguinolog
commented
Mar 14, 2024
| @@ -344,3 +346,54 @@ def test_large_selectable(self): | |||
| widget.keypress(reduced_size, "down") | |||
|
|
|||
| self.assertEqual(pos_1_down_rendered, widget.render(reduced_size).decoded_text) | |||
|
|
|||
| def test_hinted_len(self): | |||
| class HintedWalker(urwid.ListWalker): | |||
There was a problem hiding this comment.
This is for single test only and not pretend for fully correct work
* Convert `__len__` and `__length_hint__` of `ListBox` to properties: `AttributeError` will be properly handled by `getattr` / `hasattr` * Reset to the absolute render way in case of the all contents are expected to be rendered * better handling of decorated widgets for scrolling
penguinolog
force-pushed
the
scrollbar_estimated_size
branch
from
569ca14
to
8c34f9a
Compare
Pull Request Test Coverage Report for Build 8286323264Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__len__and__length_hint__ofListBoxto properties:AttributeErrorwill be properly handled bygetattr/hasattrChecklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment