Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: partial update of screenshots #873

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Docs: partial update of screenshots #873

merged 1 commit into from
Apr 16, 2024

Conversation

penguinolog
Copy link
Collaborator

  • Better symbols coverage -> less substituted characters
  • Updated BigText (more fonts)
  • Updated Tour (scrollbar)
  • Updated browse caller to use Ubuntu installable python docs
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Docs: partial update of screenshots
0ba7839 
* Better symbols coverage -> less substituted characters
* Updated `BigText` (more fonts)
* Updated `Tour` (scrollbar)
* Updated browse caller to use Ubuntu installable python docs
@github-actions github-actions bot added the docs Issues related to documentation label Apr 15, 2024
penguinolog
penguinolog commented Apr 15, 2024
View reviewed changes
docs/tutorial/hmenu1.png
Copy link
Collaborator Author

@penguinolog penguinolog Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see symbol change for submenu. In the code is set "\N{HORIZONTAL ELLIPSIS}" for symbol, so looks like screenshot is outdated.

penguinolog
penguinolog commented Apr 15, 2024
View reviewed changes
docs/examples/browse.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have issue with screenshot making for this part: in 100% cases captured incomplete render/empty screen

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is browse.py not working properly when run locally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it works almost properly: highlight is not visible (separate bug present)

penguinolog
penguinolog commented Apr 15, 2024
View reviewed changes
docs/examples/tour.py.xdotool
@@ -1,2 +1,2 @@
windowsize --usehints $RXVTWINDOWID 39 25
key --window $RXVTWINDOWID Return Page_Down Page_Down Page_Down Page_Down Page_Down
key --window $RXVTWINDOWID Return End
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page down chain ends in the different place and looks ugly

penguinolog
penguinolog commented Apr 15, 2024
View reviewed changes
docs/examples/bigtext.py.xdotool
@@ -1,3 +1,3 @@
windowsize --usehints $RXVTWINDOWID 39 21
key --window $RXVTWINDOWID BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace BackSpace e x a m p l e Down Down Down Down Down Down Return
key --window $RXVTWINDOWID Down Down Down Down Down Down Down Down Return
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we removed version part from the demo, so backspace chain is not needed

penguinolog
penguinolog commented Apr 15, 2024
View reviewed changes
docs/examples/browse.py
@@ -6,5 +6,5 @@

import real_browse

os.chdir("/usr/share/doc/python")
os.chdir("/usr/share/doc/python3")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3-doc install here on ubuntu

@penguinolog penguinolog merged commit 761c19b into urwid:master Apr 16, 2024
2 checks passed
@penguinolog penguinolog deleted the update_screenshots branch April 16, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardi wardi Awaiting requested review from wardi

@ulidtko ulidtko Awaiting requested review from ulidtko

Assignees
No one assigned
Labels
docs Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penguinolog @wardi