Skip to content

Fix browse example #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
penguinolog merged 1 commit into from
Jun 7, 2024
Merged

Fix browse example #895

penguinolog merged 1 commit into from
Jun 7, 2024

Conversation

@penguinolog
Copy link
Collaborator

@penguinolog penguinolog commented Jun 6, 2024 •
edited
Loading

Fix: #892
Fix: #641

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@penguinolog @Xtinc
Fix browse example
8af1bb8 
Fix: urwid#892 urwid#641

Co-authored-by: Xtinc <remingtonscarlet@outlook.com>
@github-actions github-actions bot added the docs Issues related to documentation label Jun 6, 2024
@penguinolog penguinolog requested a review from wardi June 6, 2024 06:48
@coveralls
Copy link

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9396368632

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.718%
Totals Coverage Status
Change from base Build 9347791057: 0.0%
Covered Lines: 9401
Relevant Lines: 12728
💛 - Coveralls

@penguinolog penguinolog requested a review from ulidtko June 6, 2024 07:12
@penguinolog penguinolog added the bug label Jun 6, 2024
@penguinolog penguinolog merged commit ab43640 into urwid:master Jun 7, 2024
@penguinolog penguinolog deleted the example_browse branch June 7, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wardi wardi Awaiting requested review from wardi

@ulidtko ulidtko Awaiting requested review from ulidtko

Assignees

No one assigned

Labels

bug docs Issues related to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] interface changes make example/browser.py doesn't work as before [docs] docs/examples/browse.py behavior is incorrect

2 participants

@penguinolog @coveralls