Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridFlow fixes for empty container #901

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

penguinolog
Copy link
Collaborator

@penguinolog penguinolog commented Jun 11, 2024

  1. No size warnings if container empty and render size set
  2. Only FLOW render supported for empty container

Fix: #900

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

1. No size warnings if container empty and render size set
2. Only FLOW render supported for empty container

Fix: urwid#900
@@ -525,7 +532,7 @@ def _set_focus_from_display_widget(self) -> None:

def keypress(
self,
size: tuple[int], # type: ignore[override]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not full sizing

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462520221

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 74.741%

Totals Coverage Status
Change from base Build 9442702303: 0.02%
Covered Lines: 9412
Relevant Lines: 12740

💛 - Coveralls

@penguinolog penguinolog merged commit 9b905d4 into urwid:master Jun 11, 2024
35 checks passed
@penguinolog penguinolog deleted the empty_grid_flow branch June 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a GridFlow with no children raises a warning
2 participants