Skip to content

Commit

Permalink
Merge pull request #1888 from usablica/fix-hint-element-position
Browse files Browse the repository at this point in the history
fix(hint): pass the correct targetElement to align position
  • Loading branch information
afshinm committed Mar 23, 2023
2 parents 8949fad + d1dccdf commit 233da99
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/core/hint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,11 @@ export async function addHints() {
hint.appendChild(hintPulse);
hint.setAttribute("data-step", i.toString());

const targetElement = item.element;
item.element = hint;

// align the hint position
alignHintPosition.call(this, item.hintPosition, hint, item.element);
alignHintPosition.call(this, item.hintPosition, hint, targetElement);

hintsWrapper.appendChild(hint);
});
Expand Down

1 comment on commit 233da99

@vercel
Copy link

@vercel vercel bot commented on 233da99 Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

intro-js – ./

intro-js-tinyapp.vercel.app
intro-js-git-master-tinyapp.vercel.app
intro-js-alpha.vercel.app

Please sign in to comment.