Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a case where .oncomplete and .onexit callbacks run both #458

Closed
wants to merge 1 commit into from
Closed

Fixes a case where .oncomplete and .onexit callbacks run both #458

wants to merge 1 commit into from

Conversation

mkarajohn
Copy link

Fixes .onexit callbacks firing when user hits Enter on 'Done' button, of last step.

Since there is a clear distinction between a 'complete' and an 'exit' event, I think it is wrong behaviour to fire 'exit' callbacks when the intro was 'completed'

… of last step.

Since there is a clear distinction between a 'complete' and an 'exit' event, I think it is wrong behaviour to fire both callbacks when the intro was 'completed'
@mkarajohn
Copy link
Author

@afshinm is this acknowledged?

@rhyous
Copy link

rhyous commented Feb 9, 2016

I disagree. Complete is when done is clicked. Exit is whenever IntroJs closes, which includes after Complete runs.

So when clicking done, two events should occur: oncomplete and onexit.

@stale
Copy link

stale bot commented Oct 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 13, 2020
@stale stale bot closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants