Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a distinction between reserved and unreserved identifiers #1

Closed
usadson opened this issue May 16, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@usadson
Copy link
Owner

usadson commented May 16, 2023

Describe the bug
At the moment, reserved and unreserved identifiers are categorized under the same type: Keyword. This is disadvantageous because of the extend to which this enumeration is built. For example, commonly used identifiers such as id, number, etc. are recognized as keywords, when in practice they're used as colomn names and table names.

To Reproduce
Steps to reproduce the behavior:

CREATE TABLE table1 (
  id INT,
  number INT
);

Expected behavior
These identifiers should only be disallowed in certain contexts, but not in these common cases.

@usadson usadson added the bug Something isn't working label May 16, 2023
@usadson
Copy link
Owner Author

usadson commented May 20, 2023

Fixed in commit d0ca37c

@usadson usadson closed this as completed May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant