Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: remove py2 support #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jochman
Copy link

@jochman jochman commented Mar 28, 2022

I've removed typed-ast package at there are problems with this package in apple-silicon.
Also, typed ast recommends using the builtin ast module from python 3.8 and up.

I could not understand why the uts are failing, I would like to get help to fix those.

@jochman
Copy link
Author

jochman commented May 1, 2022

@usagitoneko97 Hey, what's up?

@jochman
Copy link
Author

jochman commented Aug 1, 2022

@usagitoneko97 alive mate?

@tristanlatr
Copy link

Hi @jochman,

Would it possible to keep the python dependency at python 3.6 and still use the standard ast library? We should handled gracefully the fact that type annotations from comments are not available in python 3.6 and 3.7.

Also there are many more code to cleanup while dropping support for python2. Maybe this can be done later, though.

Are you willing to fork this library and continue maintaining it? I would be down to add support for imports and define a higher level api interface. If you want we can create an organization to host a new repository for klara.

Tell me what you think.
Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants