Skip to content

Commit

Permalink
🚨 Force dependency packages to use Svelte 5 (#787)
Browse files Browse the repository at this point in the history
* ⬆️ Force Svelte 5 usage in svelte-hmr, @markuplint, and prettier-plugin-svelte
* 🔧 Update .prettierignore and Button component styles
* 📝 Add caution note about Svelte 5 compatibility issues in README.md
  • Loading branch information
usagizmo committed Apr 28, 2024
1 parent b98bc5b commit c8ec12e
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 35 deletions.
3 changes: 0 additions & 3 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,3 @@ pnpm-workspace.yaml
/apps/mockup/public/styles.css
/apps/web/.svelte-kit
/apps/web/src/lib/$generated

# prettier-plugin-svelte (waiting for Svelte 5 support)
*.svelte
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Monorepo template for creating a web application.

> [!Caution]
> Currently, `svelte-hmr`, `@markuplint`, and `prettier-plugin-svelte` do not support Svelte 5.
> We have overridden `pnpm-lock.yaml` to forcibly upgrade to Svelte 5, which may cause issues during package updates.
> When updating dependencies, please refer to [#6a5906](https://github.com/usagizmo/webapp-template/pull/787/commits/6a5906b5866623b223867c4dd5de98755821cd49) to correct `pnpm-lock.yaml`.
## What's inside?

### Uses
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/lib/components/Button.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
: 'border-zinc-300 bg-slate-50 hover:border-zinc-400 hover:bg-slate-100',
);
const classAttrs = $derived(
`font-ui inline-flex items-center justify-center space-x-1 rounded-md border px-5 py-2 text-sm duration-200 disabled:pointer-events-none disabled:opacity-40 ${kindClass}`,
`font-ui inline-flex items-center justify-center space-x-1 rounded-md border py-2 px-5 text-sm duration-200 disabled:pointer-events-none disabled:opacity-40 ${kindClass}`,
);
const blankAttrs = $derived(
href && blank
Expand Down
41 changes: 10 additions & 31 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c8ec12e

Please sign in to comment.