Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return a definitive answer on GetParameters #4

Merged
merged 2 commits into from
May 3, 2023

Conversation

ckahlo
Copy link
Contributor

@ckahlo ckahlo commented May 3, 2023

Windows relies on this call. Avoid the "FAILED" response and indicate T=1 block transmission as selected mode in any case the parameters are accessed. T=1 is the preferable way to go. If you change the ATR of the card to emulate to T=0-only then adjust the ProtocolNum here to ensure correct protocol behaviour on the host operating system.

ckahlo added 2 commits May 3, 2023 11:19
Windows relies on this call. Avoid the "FAILED" response and indicate T=1 block transmission as selected mode in any case the parameters are accessed. T=1 is the preferable way to go. If you change the ATR of the card to emulate to T=0-only then adjust the ProtocolNum here to ensure correct protocol behaviour on the host operating system.
made an error while creating the PR, now corrected
@abarisani abarisani merged commit 8c40ba2 into usbarmory:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants