Optimization of text-embeddings execution and failure handling. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added working test case for text embedding |
added 2 commits
December 8, 2021 18:33
saggu
requested changes
Dec 9, 2021
There was a problem hiding this comment.
I added some comments @kartik2112
Also, I created a PR from usc-isi-i2 to your fork - kartik2112#1
Always pull the latest changes from the main repo to your fork before creating a PR
pull latest changes in `dev` from usc-isi-i2
|
@kartik2112 any updates? |
saggu
requested changes
Jan 5, 2022
There was a problem hiding this comment.
@kartik2112 changes required for handling writing to output file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with issue #519
I updated the code so that the SentenceTransformer now generates the embeddings in batches instead of processing it line by line. The progress bar is still there. At the same time, if the default device is not available, the embedding task is re-attempted on the next GPU device.
Challenges that could be raised:
torch.cuda.getDeviceCount()will return 1, so it won't re-attempt the execution.