Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to pep8 and fix path in visualize-force-graph.md #600

Merged
merged 15 commits into from Jan 11, 2022

Conversation

GrantXie
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jan 11, 2022

Hello @GrantXie! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-11 23:00:18 UTC

Copy link
Member

@saggu saggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrantXie changes required

kwargs=self.kwargs)


'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this commented out code/unused string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the commented part

@@ -664,11 +640,12 @@ def __init__(
show_text_limit: int = 500,
node_border_color: str = None,
tooltip_column: str = None,
text_node: str = None,
text_node: str = 'false',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, instead of using string false, why not use boolean False

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to boolean False

@saggu saggu merged commit 3cc4bfe into usc-isi-i2:dev Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants