New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to pep8 and fix path in visualize-force-graph.md #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrantXie changes required
kgtk/visualize/visualize_api.py
Outdated
kwargs=self.kwargs) | ||
|
||
|
||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this commented out code/unused string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the commented part
kgtk/visualize/visualize_api.py
Outdated
@@ -664,11 +640,12 @@ def __init__( | |||
show_text_limit: int = 500, | |||
node_border_color: str = None, | |||
tooltip_column: str = None, | |||
text_node: str = None, | |||
text_node: str = 'false', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, instead of using string false, why not use boolean False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to boolean False
No description provided.