Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add additional public bus timing #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Add additional public bus timing #23

wants to merge 3 commits into from

Conversation

SwampertX
Copy link
Collaborator

@SwampertX SwampertX commented Jul 14, 2019

This PR will add a second bus timing to the display

Description

problems:

  • if a bus has no service, the bus service number is prepended with the word "bus" which is out of place
  • there is a possibility that there is a first bus, but no subsequent ones. this case is not handled
  • better still, write test cases

Motivation and Context

Currently you can only see the eta for the next incoming public bus. Since the API provides 3 timings, we could use a second one :)

How Has This Been Tested?

Nope, we are yet to set up testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant