This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Update minimist #124
Merged
Update minimist #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/neighborexpress/neighbor-express/2713zs8hg |
k8reindeer
commented
May 13, 2020
| "version": "0.0.8", | ||
| "resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", | ||
| "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=", | ||
| "version": "1.2.5", |
There was a problem hiding this comment.
Github told us to make sure it's above 0.2.1... so I think we're good :)
keithk
reviewed
May 14, 2020
keithk
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
GIF/Screenshots:
Changes:
npm uninstall --save eslintnpm install --save-dev eslintWhat this did was reinstall eslint with all of its dependencies upgraded (including minimist). Now minimist is above the recommended version!
Then made a change to the lint config because it wasn't running -- colliding with the eslint in the parent folder. Now it runs!
How To Test:
Feedback I'm looking for:
Just a 👍 that I'm not crazy!
Things left to do before deploying: