Skip to content

Commit

Permalink
remove inline styling, update button sizing/margins, lint
Browse files Browse the repository at this point in the history
  • Loading branch information
amyewang committed Jun 20, 2024
1 parent 3386c5b commit 67ac409
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
15 changes: 6 additions & 9 deletions packages/client/src/views/GrantDetailsView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,11 @@
<div class="d-flex justify-content-between align-items-center">
<b-button
variant="primary"
block
class="mr-5"
style="width: fit-content; white-space: nowrap; "
class="mr-5 text-nowrap"
:href="`https://www.grants.gov/search-results-detail/${currentGrant.grant_id}`"
target="_blank"
rel="noopener noreferrer"
size="sm"
data-dd-action-name="view on grants.gov"
@click="onOpenGrantsGov"
>
Expand All @@ -52,35 +51,33 @@
</b-button>
<div class="w-20 d-flex">
<a
class="link-primary"
class="link-primary text-nowrap"
role="button"
:variant="copyUrlSuccessTimeout === null ? 'outline-primary' : 'outline-success'"
data-dd-action-name="copy btn"
style="white-space: nowrap; "
@click="copyUrl"
>
<b-icon
:icon="copyUrlSuccessTimeout === null ? 'paperclip' : 'check2'"
aria-hidden="true"
class="mr-2"
class="mr-1"
/>
<span v-if="copyUrlSuccessTimeout === null">Copy Link</span>
<span v-else>Link Copied</span>
</a>
<div class="col-1 border-right border-dark p-2"/>

Check warning on line 68 in packages/client/src/views/GrantDetailsView.vue

View workflow job for this annotation

GitHub Actions / qa / Lint JavaScript

Expected a space before '/>', but not found
<div class="col-1 p-2"/>

Check warning on line 69 in packages/client/src/views/GrantDetailsView.vue

View workflow job for this annotation

GitHub Actions / qa / Lint JavaScript

Expected a space before '/>', but not found
<a
class="link-primary"
class="link-primary text-nowrap"
role="button"
variant="outline-primary"
data-dd-action-name="print btn"
style="white-space: nowrap; "
@click="printPage"
>
<b-icon
icon="printer"
aria-hidden="true"
class="mr-2"
class="mr-1"
/>
Print
</a>
Expand Down
2 changes: 1 addition & 1 deletion usdr-gost.code-workspace
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
// competing user settings and workplace settings. We use VSCode's "codeActionsOnSave"
// to manage linting/fixing, but users can have other settings via "formatOnSave".
// If both are on, the editor can "fix" things that are immediately flagged as lint failures.
"editor.formatOnSave": false,
"editor.formatOnSave": true,
}
}

0 comments on commit 67ac409

Please sign in to comment.