Jekyllize legacy pages #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ find www.foia.gov/ -type f -name "*.html" | xargs sed -i -e 's/\r$//'
- Moves the common legacy scripts to a single include - Add a page variable to include legacy scripts (use-legacy-scripts) - Fix the ordering of scripts (e.g. jquery should be first)
- Move popup to an include - Include popup on all pages for simplicity - Move script tag to glance.js init script
Move our main foia-styles.css to the bottom of the list so that it overrides the other included stylesheets.
Keep ordering of stylesheets.
|
Videos on the FAQ page are not working. |
|
Video tooltips on glossary page are not working. |
hbillings
approved these changes
Oct 25, 2017
| <li><a href="data.html?foia/Services/RequestDisposition.jsp?agencyName=DOJ&requestYear=2016">Department of Justice: Requests Disposition 2016</a></li> | ||
| <li><a href="data.html?foia/Services/DataRequest.jsp?agencyName=DHS&requestYear=2012">Department of Homeland Security: Requests 2012</a></li> | ||
| <li><a href="data.html?foia/Services/DataRequest.jsp?agencyName=DHS&requestYear=2014">Department of Homeland Security: Requests 2014</a></li> | ||
| <li><a href="data.html?foia/Services/DataRequest.jsp?agencyName=DHS&requestYear=2009">Department of Homeland Security: Requests 2009</a></li> |
There was a problem hiding this comment.
For the life of me I can't figure out how these changed.
There was a problem hiding this comment.
It's probably the line endings dos -> unix.
| </div> | ||
| <!-- End FOIA Template --> | ||
| </body> | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> |
There was a problem hiding this comment.
I'm guessing we didn't jekyllize this one because the sitemap is going to change anyway.
There was a problem hiding this comment.
Yes, but this PR isn't even complete. There are still some pages that need to be migrated, they are lower priority but we will get to them later.
Remove bottom margin on header to avoid overlap. Allow body to scroll. Add some margin to legacy grid on smaller screens.
|
The tooltips are working, they are just slow to load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #163
This tackles most of the legacy pages. There are a handful more to do, but will fall in another PR.