Log Level Review #28
Log Level Review #28
Conversation
…ified log levels for each log statement.
…s to `.gitignore`
Log Level Review
kafka-test/CMakeLists.txt
Outdated
| @@ -32,6 +32,9 @@ | |||
| # Cyber and Information Security Research (CISR) Group Oak Ridge National | |||
| # Laboratory | |||
| # 865-804-5161 (mobile) | |||
|
|
|||
| # NOTE: THIS FILE IS DEPRECATED AS OF 5/17/2023 AND IS NOT RECOMMENDED FOR USE. | |||
There was a problem hiding this comment.
Why is this deprecated?
There was a problem hiding this comment.
The files in the kafka-test directory are separate from the primary project, not referenced anywhere and have not been tested recently to my knowledge.
There was a problem hiding this comment.
It is added here.
Line 58 in 30e2b4d
If we run the cmake command with higher cmake version 3 at the root folder, this cmake 2.6 will report cmake version is low.
There was a problem hiding this comment.
I stand corrected, the deprecation note has been removed.
build_local.sh
Outdated
| @@ -57,6 +57,7 @@ compileSpecAndBuildLibrary(){ | |||
| buildACM(){ | |||
| # Build the ACM | |||
| echo "${GREEN}Building ACM${NC}" | |||
| rm -r build | |||
There was a problem hiding this comment.
Can we check if build folder exist before remove it?
There was a problem hiding this comment.
This check has been added to the script via CDOT-CV#11.
kafka-test/src/rdkafka_example.cpp
Outdated
| @@ -32,6 +32,8 @@ | |||
| * (https://github.com/edenhill/librdkafka) | |||
| */ | |||
|
|
|||
| // NOTE: THIS FILE IS DEPRECATED AS OF 5/17/2023 AND IS NOT RECOMMENDED FOR USE. | |||
|
|
|||
There was a problem hiding this comment.
The files in the kafka-test directory are separate from the primary project, not referenced anywhere and have not been tested recently to my knowledge.
There was a problem hiding this comment.
This deprecation note has been removed.
| RdKafka::PartitionMetadata::ISRSIterator iis; | ||
| for (iis = ip->isrs()->begin(); iis != ip->isrs()->end() ; ++iis) | ||
| std::cout << (iis == ip->isrs()->begin() ? "":",") << *iis; | ||
| logger->info(" " + std::to_string(*iis)); |
There was a problem hiding this comment.
Do we need this " " for all logger?
There was a problem hiding this comment.
I don't think we need to include " " in all logging messages. In this for loop the data should be separated by something since it was being separated before.
…d-folder-exists-before-removing Added check for build folder existence before deletion
|
This is ready for re-review! @dan-du-car |
Removed deprecation warnings for files in `kafka-test` directory.
Write output from the ASN1_Codec::filetest function directly to stdout
Changes
Reviewed and adjusted the log levels for each log statement as necessary.
Replaced std::cout & std::cerr with the logger whenever possible, except for certain cases:
Tool.cpp.Additional Changes
.gitignore.build_local.shscript to remove the 'build' directory before compilation.docker-compose.yml./kafka-testdirectory as deprecated.Testing
build_local.shanddocker-compose.yml.