Updating fix for issue #190 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmusavi
reviewed
Nov 8, 2017
|
|
||
|
|
||
| TimLogLocation driverAlertLocation = ((DriverAlertFileParser) fileParser).getLocation(); | ||
| OdeLogMsgMetadataLocation driverAlertMetadataLocation = new OdeLogMsgMetadataLocation( |
There was a problem hiding this comment.
Shouldn't we be converting the location data to their user-friendly lat/long/speed/heading formats? If so, use Position3DBuilder.odePosition3D(new DsrcPosition3D(latitude, longitude, elevation) and SpeedOrVelocityBuilder.genericSpeedOrVelocity() (you'll need to make it a public method) and HeadingBuilder (fine or coarse heading depending on what's in the log file). This comment also applies to TIM messages. They too should possibly be made user-friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding location metadata into driver alert messages