Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content/value of lrs_type is unclear #128

Closed
j-d-b opened this issue Sep 2, 2020 · 3 comments · Fixed by #177
Closed

Content/value of lrs_type is unclear #128

j-d-b opened this issue Sep 2, 2020 · 3 comments · Fixed by #177
Assignees

Comments

@j-d-b
Copy link
Collaborator

j-d-b commented Sep 2, 2020

The lrs_type property, on the metadata in v2.0 and the RoadEventDataSource object in v3.0, is noted to be a "String" with the description

Describes the type of linear referencing system used for the milepost measurements

From this description, it is not clear what the lrs_type value should be.

I'm not familiar with LRS, so I may be off the mark here, but is it feasible for lrs_type to use an enumerated type (including other)?

There is also lrs_url, so perhaps all LRS info could be refactored into an LRS object with three properties:

  1. type: an enumerated type, replaces lrs_type
  2. description: a longer description of the lrs_type, especially important if it type is other
  3. url: text url, replaces lrs_url

Whether or not any change is made to the spec, it needs to be clarified what the value of lrs_type should look like.

@Mahsa-Ettefagh Mahsa-Ettefagh added the Needs discussion This issue needs clarification/additional discussion or is inactive label Nov 5, 2020
@j-d-b
Copy link
Collaborator Author

j-d-b commented Dec 21, 2020

Top proposed solution is to deprecate lrs_type and lrs_url. These have just been carried over since v1.0 without discussion. No current producers are using them and everyone who has contributed supports deprecating/removing.

If there are objections to this, please provide comments here.

@j-d-b
Copy link
Collaborator Author

j-d-b commented Jul 8, 2021

As this will be part of the v4.0 release and no producers are using these properties right now, I think we should remove these properties rather than deprecate.

Is there any opposition to removing as opposed to deprecating?

@j-d-b j-d-b removed the Needs discussion This issue needs clarification/additional discussion or is inactive label Aug 6, 2021
@j-d-b
Copy link
Collaborator Author

j-d-b commented Dec 16, 2021

Resolved by deprecating lrs_type and lrs_url in #177.

@j-d-b j-d-b closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants