-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location verify method #199
Location verify method #199
Conversation
Deprecating location verify method from schema
Deprecate location verify method and add reference to spatial verification which defines using a GPS equipped device for verification.
Updated description of the spatial verification enumerations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sknick-iastate.
Alternatively, here's a different implementation of the same change that simplifies the specification without losing functionality (which is my goal—make WZDx easy to use and understand while still being powerful):
In addition to being simpler and requiring less documentation (the new WZDx user doesn't have to reference an enumerated type and see it only has two values), I think the Also, it makes it more clear what the buisness rule for the use of
The only downside of this approach is if we wanted to add more options than just |
@sknick-iastate let me know what you think of my above approach. |
@j-d-b sorry for the delayed response. I like your approach for changing the verification to a boolean. I'd like to get feedback at our next specification update meeting then can make the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #199 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved my alternate approach to a new issue, #213. The implementation here looks good for v4.0.
This pull request addresses the issues identified in #129. Initial discussion focused on providing a list of enumerations for the location verify method but after further discussion it was determined that verified location information should be made using a GPS equipped device (i.e. not verified through cameras, site inspection, etc). It was determined that this would be better achieved by updating the SpatialVerification enumerations to clarify that a GPS equipped device is required for verification and depreciating the
location_verify_method
.As further justification the
location_verify_method
is at the data source level and wouldn't allow for different verification types for individual road events. If this is a desired then another attribute should be added at the event level.So in summary the changes are:
location_verify_method
in the RoadEventDataSource