Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lane edge reference and clarify lane numbering #97

Closed
wants to merge 10 commits into from

Conversation

j-d-b
Copy link
Collaborator

@j-d-b j-d-b commented Jun 3, 2020

This PR resolves issues #66 and #67 by:

  1. Removing lane_edge_reference from the lane entity
  2. Adding equivalent lane_number_start_side field to the road event entity
  3. Clarifying that lane_number must start at "1" for the lane closest to the roadside edge indicated by lane_number_start_side
  4. Clarifying that an increase of lane_number by "1" represents moving one lane over away from the direction indicated by lane_number_start_side

@j-d-b j-d-b changed the title Refactor lane edge reference Refactor lane edge reference and clarify lane numbering Jun 3, 2020
@j-d-b j-d-b added the v3 label Jun 3, 2020
@sknick-iastate
Copy link
Collaborator

This looks good to me. A couple of comments based on our last spec group meeting and discussing counting shoulders, bike lanes, etc in the lane number

  • I'm not sure I would interpret that shoulder/non-vehicle lanes should be included in the lane number without the background discussion we have been having recently. Especially since I don't think most agencies include these in the lane numbering currently. It may also be due to us including shoulders in the lanes table. Should we add some text in the lane_number description that says this? It may also be good to say lane_id instead of just lane when referring to the numbering as well.

  • Should we add a shoulder with a lane number to the examples (specifically a right shoulder to road_event_id 12345 in both the multi-point and linestring example)

@rchoyler
Copy link

rchoyler commented Jul 6, 2020

Recommend NOT including shoulders in the lane numbering sequence; unless they are designed to accommodate standard vehicular travel which is equivalent to that of the main lanes (i.e. similar road surface, supports same speed limit, same legality, etc.); such as lanes designated for use only during rush hour periods, HOV/HOT lanes, etc. Perhaps "unimproved shoulders" could be designated as LS (left shoulder) & RS (right shoulder). If numeric values are required, then perhaps use 0 for the left shoulder and 99 for the right shoulder.

@j-d-b
Copy link
Collaborator Author

j-d-b commented Aug 7, 2020

Note #94 completely replaces this. If #94 is not approved/merged, this PR will again be relevant. If #94 if merged, this PR can be closed.

@j-d-b
Copy link
Collaborator Author

j-d-b commented Sep 1, 2020

Closed with #94 merge

@j-d-b j-d-b closed this Sep 1, 2020
@j-d-b j-d-b deleted the refactor-lane-edge-reference branch September 18, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants