-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lane edge reference and clarify lane numbering #97
Conversation
This looks good to me. A couple of comments based on our last spec group meeting and discussing counting shoulders, bike lanes, etc in the lane number
|
Recommend NOT including shoulders in the lane numbering sequence; unless they are designed to accommodate standard vehicular travel which is equivalent to that of the main lanes (i.e. similar road surface, supports same speed limit, same legality, etc.); such as lanes designated for use only during rush hour periods, HOV/HOT lanes, etc. Perhaps "unimproved shoulders" could be designated as LS (left shoulder) & RS (right shoulder). If numeric values are required, then perhaps use 0 for the left shoulder and 99 for the right shoulder. |
Closed with #94 merge |
This PR resolves issues #66 and #67 by:
lane_edge_reference
from the lane entitylane_number_start_side
field to the road event entitylane_number
must start at "1" for the lane closest to the roadside edge indicated bylane_number_start_side
lane_number
by "1" represents moving one lane over away from the direction indicated bylane_number_start_side