Use the classnames library in TextWidget #315
Conversation
src/js/widgets/TextWidget.jsx
Outdated
| @@ -7,14 +8,15 @@ export default function TextWidget(props) { | |||
| if (!inputType) { | |||
| inputType = numberTypes.has(props.schema.type) ? 'number' : props.type; | |||
| } | |||
| const widgetClasses = classnames(props.options.widgetClassNames); | |||
There was a problem hiding this comment.
This could be done inline below, without creating a variable. It probably doesn't matter as far as performance is concerned but I have a slight preference for putting it below unless we need widgetClasses in two places.
| @@ -84,4 +84,54 @@ describe('Schemaform <TextWidget>', () => { | |||
| tree.subTree('input').props.onBlur(); | |||
| expect(onBlur.calledWith('1')).to.be.true; | |||
| }); | |||
| it('should accept a string widgetClassNames prop', () => { | |||
| @@ -184,10 +184,14 @@ The us-forms-system code includes additional `uiSchema` functionality not found | |||
| 'value': <p>Some text</p> | |||
| }, | |||
|
|
|||
| // A string of class names that are added to the widget for the current field. | |||
| // A list of class names that are added to the widget for the current field. | |||
There was a problem hiding this comment.
I appreciate the docs update! Since the documentation on this option applies to several widgets I think they all should be changed for consistency. The other references are in CurrencyWidget, SelectWidget, and ArrayCountWidget. Can you update those as well? I'm fine with just having the existing test on TestWidget for class names rather than duplicating it for the other widgets.
|
@dmethvin-gov Thanks for the review! I made the changes you requested. Mind taking another look? I'd normally use GitHub's UI to request another review, but it turns out I can't. 🤷♂️ |
Closes #314.
Like it says on the tin, this uses the
classnameslibrary in theTextWidgetfor thewidgetClassNamesoption.Types of changes
Checklist:
npm run lint.npm run build.lib/, so I'm not sure what to do about that... 😕npm test.