-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
medium less #922
Merged
Merged
medium less #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mostly working. Images still refer back to Medium. - Ported two blogs but the 9 years has a TON of references to other medium blog posts. So, we need to port all of them or is an external link ok? We probably need to target="_blank" all these links. - Fixed broken css build (space was deleted in the package.json script). Straight up wasn't working but the .css output files are checked into github, so changing the source wasn't triggering a rebuild? Need to clean up the scss build.
- Updated README with instructions. - Added 5 more blog posts TODO: - All reference images still in Medium - `carousel_show: true` is set for all, so the carousel is getting pretty full.
There are 238 Medium posts to date. Breaking up into years will help keep things organized. Moving them into sub directories didn't require a code change?
- Whole paragraphs that should be italic were messed up because they included links. - Added some `<br> ` to add extra paragraph spacing in selective locations (when the previous paragraph ended with a photo.
…me and reorganize scss to allow for properly watching and updatding all scss on changes
…r fontmatter, add conditional to template to display readtime on show pages separate from date_str
… /mission for rel link in post
…gpost for consistency
… into tomn-uses/medium-less
- Move images so they are in a dir along side blog post - Fix links to images - All blog posts must be in same directory and the `permalink` in the md meta must be the same for it all to work since images don't get an abstract `permalink` and the actual path is where they are. - Renamed all the md files. Also, there ARE duplicately named posts. So the `permalink` may need a unique id suffix anyways. Auto-porting existing cross blog links is going to be tricky. <- TODO - Update ruby to 3.2.2. - Fix some sass compile issues caused by `LC_CTYPE=UTF-8` not being defined correctly on macs. TODO: update snapshots. This PR is tooo big already.
…st, update readme
- Url name conflicts exist in our medium blogs and to auto process past posts, we can't have any. The filename is fine because it's prefixed with the date (to control sort order), but the permalink needs to be short and readable. Shortcode uses a 6 chars from the medium shortcode.
update ruby version in readme
Extra slash we missed removing
Set ruby-version to 3.2.2 to be consistent with other places. WATCH FOR ISSUES.
ruby v3.2.2 in documentation
… posts. Fix error on post summary text
drew-usds
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on staging! Allllmost ready for release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.