fix project carousel #924
Merged
fix project carousel #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Tomn-uses/medium-less branch on staging
Test Tomn-uses/medium-less branch on staging: part two
Test Tomn uses/medium less: part three
updating HP project carousel and titles
- Added `carousel_show` and `carousel_image_alt_text` to the markdown "liquid" header. - Add some comments to this header. - Fix some line wrapping issues. - TODO: the `carousel_image_alt_text` is just set to `"Project photo"` for now. We should customize it.
[Draft] medium less
amwhitty
approved these changes
Jan 12, 2024
amwhitty
added a commit
that referenced
this pull request
Feb 9, 2024
* fix project carousel (#924) * Update carousel-projects.html * Make project carousels more like blog - Added `carousel_show` and `carousel_image_alt_text` to the markdown "liquid" header. - Add some comments to this header. - Fix some line wrapping issues in these headers that may have been causing issues TODO - the `carousel_image_alt_text` is just set to `"Project photo"` for now. We should customize it. (issue created) - Update documentation (issue created) * Use Ruby v3.1.3 (#926) - Was trying to use Ruby version 3.2.2 but pushing to production failed because the github docker image doesn't support it yet. The newest support version listed is 3.1.3 so trying that. - Noticed the `Gemlock.lock`'s `PLATFORMS` got trimmed down. Doing experiment to see if it matters. * Update Gemfile.lock (#927) * Update Gemfile.lock PLATFORMS experiment failed. Reset to old value * Update deploy.yml Try bumping cache-version to force 3.1.3 * Fixes to prod (#928) * Fix one broken link in blog * Read application.css Apply form needs this file. Not able to test on staging site. * x-twitter icon change (#931) - Update twitter logo to X - Remove Facebook link - Bring up-to-date with main * Fix minor Apply iframe height issue. (#929) * Fix minor Apply iframe height issue. In some situations, the Apply iframe is too short and it gets a nested scrollbar. It's most obvious when changing the "zoom" size or if viewing on mobile. Fix changes: - size to use `rem/em` vs `px` for browser zoom levels - uses "mobile first" breakpoint that's taller for mobile and shorter for desktop. No good way to test in localhost and staging because the iframe won't load. Attempted to test by applying new sizes to the production site via the debugger. Rebuilding the css is problematic. Still must delete the style.css file and run the *release build* to get the correct output (not the `serve` or `start). * Add breakpoints for tablet and desktop - `var frameResizedHeight = parseInt(height) + 25;` => `const frameResizedHeight = parseInt(height) + 307;` for the salesforce callback. - Adjusted reactive css for Apply form to handle case where user resizes the browser. It's set to max height when both the "how did you hear about usds" and "portfolio = design cop" are selected in the form. * add scheduled maintenance banner to apply.yml content * press logo updates * Press hits edit (#935) * add 6 articles * Update news_articles.yml * add press logos * add press logo * Add AI blog (#934) * initial draft * add URLs * typo * add AI blog image * add folder * image file path * edit card summary * Update _news-and-blog/2024-01-29-a-call-to-service-for-talent-in-the-federal-government.md Co-authored-by: Drew Gardner <57154955+drew-usds@users.noreply.github.com> * Update _news-and-blog/2024-01-29-a-call-to-service-for-talent-in-the-federal-government.md Co-authored-by: Drew Gardner <57154955+drew-usds@users.noreply.github.com> --------- Co-authored-by: Drew Gardner <57154955+drew-usds@users.noreply.github.com> --------- Co-authored-by: TomNUSDS <Thomas.A.Nielsen@omb.eop.gov> Co-authored-by: drew-usds <57154955+drew-usds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.