Fix html headers #943
Merged
Fix html headers #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added two headers that were reported as missing: `<meta name="robots" ` and `<meta property="og:image:alt" `
- `<meta name="robots" content="noindex, nofollow" />` was there for non-production and if the `page.hide_from_search` was set; however, the inverse of `<meta name="robots" content="index" />` wasn't there.
- `<meta property="og:image:alt"` is a 508 string. It's dynamic depending on the image being displayed. Pages will need to include a `social_image_alt_text` or `carousel_image_alt_text` with their custom images.
- Started using`{%-` and `-%}` which removes the blank line feeds from the output. When an eng candidate might look at our source, all the blank spaces look pretty sloppy.
- Move the 5x-step if/else logic out of a single line and into separate lines at the top of the file so it is readable.
- Repeated process for other variables to be consistent.
- Split out the `application/ld+json` json into multiple lines to be more readable. It is super confusing because `{{` could be json OR Jekyll syntax. Fixed at least one bug related to this confusion.
TomNUSDS
commented
Mar 12, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
drew-usds
reviewed
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
<meta name="robots"and<meta property="og:image:alt"<meta name="robots" content="noindex, nofollow" />was there for non-production and if thepage.hide_from_searchwas set; however, the inverse of<meta name="robots" content="index" />wasn't there.<meta property="og:image:alt"is a 508 string. It's dynamic depending on the image being displayed. Pages will need to include asocial_image_alt_textorcarousel_image_alt_textwith their custom images.{%-and-%}which removes the blank line feeds from the output. When an eng candidate might look at our source, all the blank spaces look pretty sloppy. Also, hurting code readability to prevent extra whitespace in output is an anti-pattern.application/ld+jsonjson into multiple lines to be more readable. It is super confusing because{{could be json OR Jekyll syntax. Fixed at least one bug related to this confusion.How I tested:
mainbranch, use thebuildorbuild-stagingto generate the static html into_site_site_main