Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray <base target> #951

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Remove stray <base target> #951

merged 2 commits into from
Mar 28, 2024

Conversation

TomNUSDS
Copy link
Contributor

  • This was causing a new tab to be opened when clicking on the nav bar while on these pages /projects/ssa/ and /projects/healthcare-renewals/
  • This was may have been causing DAP issues because tracking across new tabs?
  • Renamed 0008__medicaid.md to 0008_medicaid.md (double __ -> single _)

- This was causing a new tab to be opened when clicking on the nav bar while on these pages `/projects/ssa/` and `/projects/healthcare-renewals/`
- This was may have been causing DAP issues because tracking across new tabs?
- Renamed `0008__medicaid.md` to `0008_medicaid.md` (double __ -> single _)
@TomNUSDS TomNUSDS requested a review from amwhitty March 28, 2024 17:48
@TomNUSDS TomNUSDS self-assigned this Mar 28, 2024
@TomNUSDS
Copy link
Contributor Author

@amwhitty Also, until we add the carousel_show: true, it won't be findable on the site.

# accessibility text for image
carousel_image_alt_text: "Project photo"
# should show on home page. ordered by date prefix in filename
carousel_show: true

I'm happy to add that as part of the PR, but wanted to check first.

We are out of space with the numbering. We'll need to renumber soon or switch to a date prefix (which avoids this issue completely).
Copy link
Contributor

@amwhitty amwhitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomNUSDS TomNUSDS merged commit 03790c1 into master Mar 28, 2024
@TomNUSDS TomNUSDS deleted the tomn-usds/remove-base-target branch March 28, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants