-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/storage api #28
Conversation
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 92.00% 92.85% +0.85%
==========================================
Files 3 3
Lines 50 56 +6
Branches 17 22 +5
==========================================
+ Hits 46 52 +6
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
@Stalkakuma Another common thing people do is add a description in the PR, pointing to the ticket and explaining what changed. It's not required here, but would be nice as a practice. And you can do stuff like include "Closes !" text to automatically close the ticket after this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Just a note on tests when you add them: the basic tests for the storage should essentially be the same as existing ones, but just use different storage; maybe it's even worth using the same tests, and iterate over them several times for different storage options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think we should merge Cypress tests first and then we can wrap up with this one!
...
(stand in for commits I did not address, yet)
...
Packages added:
Done:
TODO: