-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate abi/metadata package #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Robbepop
reviewed
Jun 23, 2020
Robbepop
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Robbepop
approved these changes
Jun 24, 2020
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39.
Generating metadata requires a separate workspace package which is invoked via
cargo run --package abi-gen
. Currently this is generated by the template and exists statically in the contract's workspace.This PR instead dynamically generates the
abi-gen
package, adding it to the contract workspace before invoking it. This simplifies the contract's workspace, and also allows changes to the metadata generation process without relying on all contract authors to update their localabi-gen
packages.Template updated to be
ink/master
compatibleLimitations
ink! v2
contracts. Agreed with @Robbepop that this is too much work.ink-as-dependency
sub contracts in a multi contract workspace (e.g.delegator
). I began to write code for this, it's possible but requires several more hours work. This could be addressed in a follow up Generate metadata for sub-contracts in multi contract workspace #60, since we don't currently support this anyway.todo
workspace
module into files, for easier review hereink/examples/dns
ink/examples/delegator