Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract contract metadata to its own crate #69

Merged
merged 18 commits into from
Sep 10, 2020
Merged

Extract contract metadata to its own crate #69

merged 18 commits into from
Sep 10, 2020

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Aug 5, 2020 •
edited
Loading

Closes #65, rel use-ink/ink#299.

Not sure about the name: have called it contract-metadata for now.

/cc @seanyoung

@ascjones ascjones requested a review from Robbepop August 5, 2020 11:16
Robbepop
Robbepop suggested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all look good. However, I'd really like to see a builder for construction.

metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
@ascjones
Copy link
Collaborator Author

ascjones commented Sep 1, 2020

@Robbepop ready for another look now I've added the builder

Robbepop
Robbepop reviewed Sep 10, 2020
View reviewed changes
metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
metadata/lib.rs Outdated Show resolved Hide resolved
Robbepop
Robbepop reviewed Sep 10, 2020
View reviewed changes
metadata/lib.rs Outdated Show resolved Hide resolved
Robbepop
Robbepop approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now
let's wait for the checks to pass and then you are free to merge

@ascjones ascjones merged commit f0e7cab into master Sep 10, 2020
@ascjones ascjones deleted the aj-metadata-crate branch September 10, 2020 13:51
@ascjones ascjones mentioned this pull request Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract extended contract metadata types to separate crate
2 participants
@ascjones @Robbepop