chore: refactor patron from <InputFile/> into <Step1/>
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peetzweg
changed the title
<InputFile/> and <Step1/><InputFile/> into <Step1/>
cmichi
approved these changes
Mar 18, 2024
Passing run #385 ↗︎
Details:
Review all test suite changes for PR #529 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoists patron integration (#518) a component higher. This makes the integration only work on the
/instatiateroute. Before it was working anywhere a<InputFile />component was used.Here is a valid link to the current deployment using the patron url search parameter:
https://deploy-preview-529--contracts-ui.netlify.app/instantiate?patron=0efaf17fd9145a2c7d59821aea6036549f4b6f2d0c86440a16d4c1ac9d57a295
Furthermore, making
File=>FileStatelogic reusable by putting them into a dedicated file,fileToFileState.ts.https://github.com/peetzweg/contracts-ui/blob/3cf8d2beda078f77a5ce4e056f929bff074268df/src/lib/fileToFileState.ts#L6-L8
cc @o-tsaruk