Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize seal_call #1041

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Stabilize seal_call #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
173b246
Stabilize `seal_call`
cmichi Nov 24, 2021
0694503
Merge branch 'master' into cmichi-stabilize-seal-call
cmichi Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ This is the 7th release candidate for ink! 3.0.
- Annotating a wildcard selector in traits is not supported.

## Changed
- Upgraded to the unstable `seal_call` API ‒ [#960](https://github.com/paritytech/ink/pull/960).
- Upgraded to the `seal_call` v1 API ‒ [#960](https://github.com/paritytech/ink/pull/960).
- This API now enables control over the behavior of cross-contract calls, e.g. to forward/clone input,
enable tail calls and control reentrancy.
The crate documentation contains more details on the [`CallFlags`](https://paritytech.github.io/ink/ink_env/struct.CallFlags.html).
- **Note:** The default behavior of cross-contract calls now disallows reentering the calling contract.
- **Note:** In order to support this you currently have to enable the `unstable-interface` of
the `contracts` pallet, [like here](https://github.com/paritytech/substrate-contracts-node/blob/main/runtime/Cargo.toml#L104-L108).
- ink! contract definitions via `#[ink::contract]`:
- ink! smart contracts now generate two contract types. Given `MyContract`:
- `MyContract` will still be the storage struct.
Expand Down
6 changes: 3 additions & 3 deletions crates/env/src/engine/on_chain/ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,7 @@ mod sys {
output_ptr: Ptr32Mut<[u8]>,
output_len_ptr: Ptr32Mut<u32>,
);
}

#[link(wasm_import_module = "__unstable__")]
extern "C" {
pub fn seal_call(
flags: u32,
callee_ptr: Ptr32<[u8]>,
Expand All @@ -326,7 +323,10 @@ mod sys {
output_ptr: Ptr32Mut<[u8]>,
output_len_ptr: Ptr32Mut<u32>,
) -> ReturnCode;
}

#[link(wasm_import_module = "__unstable__")]
extern "C" {
Comment on lines +328 to +329
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've been removed in #1036, no? Do you need to merge master?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still seal_ecdsa_recover which is unstable, but I just merged master and there were some conflicts to resolve because of that PR, so good to merge nontheless.

pub fn seal_ecdsa_recover(
// 65 bytes of ecdsa signature
signature_ptr: Ptr32<[u8]>,
Expand Down