README fixes #1570
Merged
README fixes #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to choose between 'the' and 'our'.
It was repeated twice.
Otherwise it fails with 'ERROR: cargo-contract cannot build using the "stable" channel.'.
This is especially useful when viewing on https://paritytech.github.io/ink/.
They all need it.
Let's keep it consistent.
This is grammatically-correct.
Riot has been renamed to Element.
ilovehackathons
requested review from
cmichi,
ascjones and
HCastano
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
- Coverage 71.61% 71.55% -0.07%
==========================================
Files 205 205
Lines 6296 6296
==========================================
- Hits 4509 4505 -4
- Misses 1787 1791 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HCastano
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Remove 'the' to correct the grammar Have to choose between 'the' and 'our'. * Remove the word 'file' to correct the grammar It was repeated twice. * Add '+nightly' to the build command Otherwise it fails with 'ERROR: cargo-contract cannot build using the "stable" channel.'. * Make the word 'examples' into a link This is especially useful when viewing on https://paritytech.github.io/ink/. * Add '+nightly' to another build command They all need it. * Add another missing '+nightly' Let's keep it consistent. * Use fields (plural) instead of field (singular) This is grammatically-correct. * Convert the Riot link into an Element link Riot has been renamed to Element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+nightlymissing in build commands, grammar fixes, etc.