Fix remaining unchecked arithmentic in examples #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkymanOne
approved these changes
Oct 3, 2023
agryaznov
approved these changes
Oct 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
+ Coverage 52.88% 52.91% +0.02%
==========================================
Files 219 219
Lines 6781 6781
==========================================
+ Hits 3586 3588 +2
+ Misses 3195 3193 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pgherveou
approved these changes
Oct 3, 2023
smiasojed
approved these changes
Oct 3, 2023
In the unlikely event of an overflow we definitely want to panic instead of wrapping around to |
ascjones
added a commit
that referenced
this pull request
Oct 4, 2023
* Fix unchecked arithmetic on remaining integration-tests * Fix * Fix
ascjones
added a commit
that referenced
this pull request
Oct 17, 2023
* Update contract_size.sh script * Add --quiet option to for_all_contracts_exec.sh * Bash lowercase var names * Print contract dir instead of contract name because it is unique * TEMPORARILY comment out other steps * Add measurements stage with contract sizes for current branch * print result file * Add back stages * See if it works without the RUSTFLAGS * Add back RUSTFLAGS * Don't swallow build error in contract size * Just run measurements for now... * Ok restore the rest then * Do measurements before examples * Try running contract sizes for `master` * Use upstream dir * --quiet * cd into upstream dir for matching names * CI project dir * scripts dir and add todo * popd * remove todo * Add script to produce contract sizes table * awk vars * See if it works in a subdir * See if it works in a subdir, use script * before/after script * Comment * Try up a directory * Fix remaining unchecked arithmentic in examples (#1930) * Fix unchecked arithmetic on remaining integration-tests * Fix * Fix * MEASUREMENTS_DIR abs * fix script name * rules for only running on PRs * Generate markdown table from diff * Submit contract markdown table * chmod +x * Print PR_COMMENTS_URL * Use CI_COMMIT_REF_NAME var * Export vars * Don't need to cd into ink dir * Print cargo-contract version * Fix cargo-contract version regex * Fix * Try to fix json body generation * Fix formatting * master_ahead * Update link * Trim contract names with integration-tests prefix * Add change column * Don't display vars * Try remove RUSTFLAGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1831, using checked arithmetic