Fix selector encoding #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By encoding as array of strings instead of a stringified array.
|
Will merge as soon as Polkadot JS side is ready. |
Robbepop
approved these changes
Nov 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 41.73% 41.73%
=======================================
Files 55 55
Lines 3680 3680
=======================================
Hits 1536 1536
Misses 2144 2144
Continue to review full report at Codecov.
|
Merged
|
Superseeded by #296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By encoding as array of strings instead of a stringified array.
Before:
After:
Needs to be communicated to polkadot-js before merge.