Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI check format of UI tests #534

Merged
merged 18 commits into from
Nov 11, 2020
Merged

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Oct 22, 2020

Closes #531.

@cmichi cmichi marked this pull request as draft October 22, 2020 07:30
@cmichi
Copy link
Collaborator Author

cmichi commented Oct 22, 2020

Currently blocked by rust-lang/rustfmt#4487.

Edit: I've provided rustfmt with a PR to fix the above issue, the PR has been merged in the meantime. Now we just have to wait until 1.4.23 is released.

@codecov-io
Copy link

codecov-io commented Nov 10, 2020

Codecov Report

Merging #534 (b54bcce) into master (402a694) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   67.87%   67.25%   -0.63%     
==========================================
  Files         155      155              
  Lines        6826     6895      +69     
==========================================
+ Hits         4633     4637       +4     
- Misses       2193     2258      +65     
Impacted Files Coverage Δ
...es/lang/macro/tests/ui/pass/02-flipper-contract.rs 8.33% <0.00%> (ø)
...tes/lang/macro/tests/ui/pass/05-erc721-contract.rs 0.59% <0.00%> (-0.44%) ⬇️
crates/storage/src/collections/hashmap/mod.rs 97.54% <0.00%> (-0.81%) ⬇️
...ates/storage/src/collections/hashmap/fuzz_tests.rs 100.00% <0.00%> (+5.47%) ⬆️
crates/storage/src/collections/hashmap/impls.rs 94.11% <0.00%> (+9.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402a694...b54bcce. Read the comment docs.

@cmichi
Copy link
Collaborator Author

cmichi commented Nov 10, 2020

My rustfmt PR has been merged and is in the latest release. So this PR is ready for review now.

@cmichi cmichi marked this pull request as ready for review November 10, 2020 20:42
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, @cmichi ! :)

@cmichi cmichi merged commit fe82d17 into master Nov 11, 2020
@cmichi cmichi deleted the cmichi-make-ci-check-fmt-of-ui-tests branch November 11, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI does not trigger a failure on TODO comments in UI tests
3 participants