Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Warn before closing Environment Configuration #1072

Open
edbrannin opened this issue Nov 28, 2023 · 1 comment
Open

[Feature] Warn before closing Environment Configuration #1072

edbrannin opened this issue Nov 28, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@edbrannin
Copy link
Contributor

Steps to reproduce:

  1. Click on Environment selector
  2. Click Configure
  3. (Create an Environment if none exists yet)
  4. Add a row to the Environment table, then type in it
  5. One of:
    • Press the 'X' in the upper-right
    • Click anywhere outside the modal

Expected result:

One of:

  • The modal prompts before closing (like closing a Request with changes)
  • The modal auto-saves (I think this is the worse option)

Observed Result

The modal immediately closes. My changes are not saved.

Notes

As @martinsefcik suggested in #1040, the easiest way to resolve this issue (and that one) might be to make Environments a tab, like Variables, Runner, & Collection [Settings].

@sanjai0py sanjai0py added enhancement New feature or request good first issue Good for newcomers labels Jul 3, 2024
@hrehovam
Copy link

hrehovam commented Oct 5, 2024

@sanjai0py Hi, I am student of Technical University of Košice, Slovakia. One of our subjects is about resolving open source issues and I would like to work on this one. Can I work on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants