Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misspelling #1280

Closed
ghost opened this issue Dec 26, 2023 · 8 comments · Fixed by #1299
Closed

fix misspelling #1280

ghost opened this issue Dec 26, 2023 · 8 comments · Fixed by #1299

Comments

@ghost
Copy link

ghost commented Dec 26, 2023

only HTTP, HTTPS, SOCKS4 and SOCKS5 are the correct spelling

bruno

@CRAZy-Monk3Y
Copy link
Contributor

Hi @helloanoop, I made a pull request that fix this. Can you please approve this pull request #1299

@helloanoop
Copy link
Contributor

@CRAZy-Monk3Y

I feel the smallcase is cleaner, less noisy and elegant.
Is this just a preference / Is there a technical reason why it should be Capitalised ?

image

@CRAZy-Monk3Y
Copy link
Contributor

@helloanoop It was an issue requested by an user.
Although there is no direct technical reasoning. Using standardized spellings like HTTP, HTTPS, SOCKS4, and SOCKS5 aligns with globally accepted conventions and industry standards. Consistent terminology enhances code readability and maintains cohesion with widely recognized naming conventions. This conformity fosters a more accessible and comprehensible codebase, facilitating collaboration and reducing potential confusion among developers.

@helloanoop
Copy link
Contributor

Hmm..

It was an issue requested by an user.

Do you have a link to the issue / conversation ?

I actually prefer smallcase, its clean and eleqouent.
@Its-treason @mirkogolze Do you guys have a strong stance that we should capitalize it ?

@Its-treason
Copy link
Member

I think we should use the correct / most used spelling for all words, and HTTPS, SOCKS5 etc. seems to be written in UPPERCASE everywhere. So I would vote for merging #1299.

@mirkogolze
Copy link
Contributor

In alignment to the often used environment variables for proxies, I'd would prefer upper case too.

@CRAZy-Monk3Y
Copy link
Contributor

CRAZy-Monk3Y commented Jan 26, 2024

Do you have a link to the issue / conversation ?

Actually this is the issue thread raised by a deleted user where I got to know about this.

@helloanoop
Copy link
Contributor

Thank you @CRAZy-Monk3Y @Its-treason @mirkogolze !

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants