Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMD+A (Mac) does not select all text in the key column of headers, assertions or vars #131

Closed
dcoomber opened this issue Mar 18, 2023 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dcoomber
Copy link
Member

When amending the headers, assertions or vars of a request, the user cannot use CMD+A to select all text in the key column (left-most column).

This is inconsistent with the value column where CMD+A can be used to select all text.

Screen.Recording.2023-03-18.at.11.06.24.mov

Workaround: The user can use the the mouse or CMD+SHIFT+ARROW to select the key text.

@dcoomber
Copy link
Member Author

At the risk of overloading this issue, I've noted that CMD+A is also ignored on dialogs for creating / renaming requests.

@helloanoop
Copy link
Contributor

Need to hunt down this issue which is only affecting mac users.
Also, we need to make the select dropdowns blend well with the dark mode.

Both of these are good first issues for anyone in the community to pick up.

@helloanoop helloanoop added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Mar 19, 2023
@vishnuroshan
Copy link

I want to work on this!!

@helloanoop
Copy link
Contributor

Hey @vishnuroshan
That'd be great!

He are instructions to getting it run on local
https://github.com/usebruno/bruno/blob/main/docs/development.md

If you need help, please ping in the dev channel on our Discord

@helloanoop
Copy link
Contributor

Finally, this issue has been fixed. The solution was to update the menu template to include selectall.
Looking forward to get this out in the upcoming v0.15.0 release

image

@helloanoop
Copy link
Contributor

At long last Bruno Version 0.15.0 happily bids adieu to this issue 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants