Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Interpolation #1460

Open
helloanoop opened this issue Jan 27, 2024 · 2 comments · Fixed by #1461
Open

String Interpolation #1460

helloanoop opened this issue Jan 27, 2024 · 2 comments · Fixed by #1461

Comments

@helloanoop
Copy link
Contributor

helloanoop commented Jan 27, 2024

String Interpolation

Goal

Today our interpolation logic is duplicated across multiple packages (App, Electron, CLI)
The goal is to centralize a single source of truth for all interpolation logic.

Considerations

Moving away from handlebars

I think its time to move away from handlebars.
We don't need the full power of handlebars and we want write a custom interpolation function that meets our needs instead of shoehorning handlebars to match our use case.

Related Tickets

@helloanoop
Copy link
Contributor Author

I have a working PR.

@nelup20 @martinsefcik @Its-treason @mirkogolze Requesting Review.

helloanoop added a commit that referenced this issue Jan 28, 2024
* feat(#1460): string interpolation

* chore: deleted file commited accidentally
@helloanoop helloanoop reopened this Jan 29, 2024
@helloanoop
Copy link
Contributor Author

I have integrated the new common interpolation librray with App, Electron and CLI.

Have also started maintain a test suite via a collection that is also run as a part of github action
The test suite should give us more confidence in refactoring code in the future

Also happy to bid adieu to Handlebars. We were clearly shoehorning our use case into it. The new interpolation function has extensive tests cases matching our requirements and we can keep adding more cases in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant