Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should have access to About menu to find out what version they are currently using #203

Closed
jeffprinty opened this issue Sep 23, 2023 · 5 comments

Comments

@jeffprinty
Copy link
Contributor

jeffprinty commented Sep 23, 2023

Many apps will provide an About page in the help menu to allow users to know what version of the app is currently being used. Bruno should also have this too.

Example: As a Mac user I want to see if I have the latest Mac version of the app to know if the collections scrolling should be working. Currently there is no way to know what version of Bruno is running

Proposal: Use electron-about-window package to implement a basic About window in the Help menu

jeffprinty added a commit to jeffprinty/bruno that referenced this issue Sep 23, 2023
jeffprinty added a commit to jeffprinty/bruno that referenced this issue Sep 23, 2023
helloanoop added a commit that referenced this issue Sep 23, 2023
@helloanoop
Copy link
Contributor

This is cool !!

PR Merged. Thanks @jeffprinty !

@helloanoop
Copy link
Contributor

I have released this changes.

This works in local
image

But is broken in the released build. Need to investigate.
image

@mirkogolze
Copy link
Contributor

you could try

icon_path: join(process.cwd(), '/resources/icons/png/256x256.png'), 

@alefteris
Copy link

An issue from another user has also been opened for the broken app image in the about window #254. Since the about window is already implemented and released, I think the current issue can be resolved and track the icon issue in the new one?

Also a feature request for the about window has been opened at #231, requesting for the version text to be able to be copied.

mirkogolze pushed a commit to mirkogolze/bruno that referenced this issue Sep 30, 2023
add icon to asar content, change styling to allow copying the content
helloanoop added a commit that referenced this issue Sep 30, 2023
#203 #254 #231 add icon to asar content, change styling to allow copying the content
@helloanoop
Copy link
Contributor

This is now working in latest release v0.16.5
image

Thank you @mirkogolze and @jeffprinty !

phoval pushed a commit to phoval/bruno that referenced this issue Oct 1, 2023
add icon to asar content, change styling to allow copying the content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants