Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFX passphrase stored in collection bru in the clear #2685

Open
2 tasks done
mattisking opened this issue Jul 22, 2024 · 2 comments
Open
2 tasks done

PFX passphrase stored in collection bru in the clear #2685

mattisking opened this issue Jul 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mattisking
Copy link

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

The recent landing of pfx support for certs is great, thanks for that. However, the passPhrase is currently stored in the clear in the collection bru file, meaning it’s also going to go into Git (for most people).

Why not make this use the same secrets logic you have for secret variables.

.bru file to reproduce the bug

Not really necessary. You can see this if you simply add a PFX cert with its passphrase.

Screenshots/Live demo link

Not needed.

@mattisking mattisking added the bug Something isn't working label Jul 22, 2024
@pietrygamat
Copy link
Contributor

Interestingly, the pfx passphrase is being interpolated, which means bru file like this works, assuming the password is stored in environment variable pfx_pass - which may be marked as a secret.

"clientCertificates": {
    "enabled": true,
    "certs": [
      {
        "domain": "*",
        "type": "pfx",
        "pfxFilePath": "certs/client.example.com.p12",
        "passphrase": "{{pfx_pass}}"
      }
    ]
  }

@mattisking
Copy link
Author

Ah great. That’ll work for me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants