Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tauri. #1104

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Remove Tauri. #1104

merged 1 commit into from
Dec 1, 2023

Conversation

nickheniser
Copy link
Contributor

@nickheniser nickheniser commented Nov 30, 2023

It seems Tauri will not be supported, so removing it.

See: #20 (comment)

closes #1099

Description

The version of Tauri in bruno-tauri brings in some dependencies which security issues which are getting packaged in the source zip. This causes false alarms when scanning the source zip for vulnerabilities, since this code is not used.

  • updated package.json to remove the packages/bruno-tauri dependency
  • removed the packages/bruno-tauri folder
  • updated package-lock.json by running npm install

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

It seems Tauri will not be supported, so removing it.

See: usebruno#20 (comment)

closes usebruno#1099
@helloanoop helloanoop merged commit d13b4d1 into usebruno:main Dec 1, 2023
@helloanoop
Copy link
Contributor

Thank you @nickheniser !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tauri / Cargo Security Issues
2 participants