Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: bump codemirror dep #1269

Merged
merged 1 commit into from Dec 23, 2023
Merged

bugfix: bump codemirror dep #1269

merged 1 commit into from Dec 23, 2023

Conversation

DeJayDev
Copy link
Contributor

Description

Closes the bug mentioned in #1268, an outdated codemirror dependency causes the bruno-app to fail to build.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop helloanoop merged commit 84905ed into usebruno:main Dec 23, 2023
2 checks passed
@helloanoop
Copy link
Contributor

Thank you for taking care of this @DeJayDev !

@helloanoop
Copy link
Contributor

@DeJayDev
The PR #1269 broke the graphql syntax highlighting as well as the schema autocomplete functionality see #1330
I have reverted the version bump for now.

@ponez
Copy link

ponez commented Jan 15, 2024

Is it still broken on 1.6.1 ?

@sanjai0py sanjai0py mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeJayDev @helloanoop @ponez