Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added bru.setNextRequest into the hint words list #1441

Merged
merged 1 commit into from Jan 25, 2024

Conversation

MultiFe22
Copy link
Contributor

@MultiFe22 MultiFe22 commented Jan 24, 2024

Description

Added bru.setNextRequest(nextRequest) into the hint words list. After #534 was closed, the new method of the Bru object wasn't added to the hint words list inside the desktop application. In this PR I'm adding it and probably will update the documentation on the website. If it wasn't for me exploring the discussion I wouldn't discover this very useful functionality.

Closes #1442

Usage:
Screenshot 2024-01-24 at 17 25 59

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@MultiFe22 MultiFe22 marked this pull request as ready for review January 24, 2024 20:27
Copy link
Contributor

@mj-h mj-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

We could alternatively use 'bru.setNextRequest(requestName)' to make sure that everyone understands that the function takes request names as input, but I'm also OK with your approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bru.setNextRequest is missing in the hint words and in the documentation.
4 participants