Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent documents menu #1582

Merged
merged 3 commits into from Feb 13, 2024
Merged

Recent documents menu #1582

merged 3 commits into from Feb 13, 2024

Conversation

j4-m
Copy link
Contributor

@j4-m j4-m commented Feb 13, 2024

Description

Closes #1521

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@j4-m
Copy link
Contributor Author

j4-m commented Feb 13, 2024

image

@helloanoop helloanoop merged commit 8287126 into usebruno:main Feb 13, 2024
@helloanoop
Copy link
Contributor

Merged!

This great. Thank you @j4-m !

@j4-m
Copy link
Contributor Author

j4-m commented Feb 14, 2024

Thanks @helloanoop. I reliased that I'd missed some changes in my PR which you've corrected in eab50f0. I probably should have mentioned that I'm not sure if this implementation is going to work cross platform as it is, I'll do some testing and get back to you.

@j4-m
Copy link
Contributor Author

j4-m commented Feb 14, 2024

Yep I'm afraid addRecentDocument is only supported on macOS and Windows but I don't have an install to test the latter.

https://www.electronjs.org/docs/latest/api/app#appaddrecentdocumentpath-macos-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recently Opened Collections
2 participants